hook addition requests

Bring Your Business to LifeSupportImage Storehook addition requests

Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #57111
    Xpark Media
    Keymaster

    @lch503,

    Will look into, would you be able to test it before is release?

    #57121
    lch503
    Participant

    Thank you,

    More than happy to at my usual email address!

    Leon

    #70191
    Xpark Media
    Keymaster

    We added the hooks in the last release, we hope it will help

    #71892
    lch503
    Participant

    Great! They have indeed!

    There is one issue in sagepay.php with the

    do_action( ‘ims_sagepay_notice_error’, $ImStore->error, $cartid );

    hook.

    Note that one on the parameters is $cartid which is not set until after the if statement. Moving the line

    $cartid = trim( $crypt_array[‘VendorTxCode’] );

    to before the if statement

    if( $crypt_array[‘Status’] != ‘OK’ ){

    fixes the issue. Apart from that the hooks work great 🙂

    Thanks again!

    Leon

    #78237
    Xpark Media
    Keymaster

    Thank you, we made the change and it will be fix on the next release

    #78664
    lch503
    Participant

    Thanks,

    Could you also make the following change to sagepay.php

    in the function add_hidden_fields( $output ),

    could you add a conditional statement for the lines

    $crypt .= ‘BillingState=’ . $data[‘billing_state’] . ‘&’;

    and

    $crypt .= ‘DeliveryState=’ . $data[‘address_state’] . ‘&’;

    as these are only required for the US, at the moment I must comment these out after every release.

    So, for example in psuedocode

    if ( currency = US dollars ) $crypt .= ‘BillingState=’ . $data[‘billing_state’] . ‘&’;

    and

    if ( currency = US dollars ) $crypt .= ‘DeliveryState=’ . $data[‘address_state’] . ‘&’;

    Thanks!

    #98437
    Xpark Media
    Keymaster

    @lch503,

    the values were added, but the data has changed to an array to allow other plugins to remove, change or add values.

    The new filter(hook) name will be ‘ims_sage_crypt_data’

Viewing 7 posts - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.